Repository navigation
fix(Session): send SameSite attribute in BaseHandler::destroyCookie() - #10748
Merged
paulbalandan merged 1 commit intoNov 13, 2026
Merged
paulbalandan merged 1 commit into
paulbalandan merged 1 commit into
Conversation
gr8man
force-pushed
the
fix/session-base-handler-cookie-samesite
branch
from
November 8, 2026 22:54
4e28581 to
80096f4
Compare
patel-vansh
approved these changes
Nov 9, 2026
paulbalandan
reviewed
Nov 9, 2026
michalsn
requested changes
Nov 12, 2026
gr8man
force-pushed
the
fix/session-base-handler-cookie-samesite
branch
from
November 12, 2026 10:40
80096f4 to
ebb4547
Compare
gr8man
force-pushed
the
fix/session-base-handler-cookie-samesite
branch
from
November 12, 2026 13:43
ebb4547 to
f892103
Compare
paulbalandan
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BaseHandler::destroyCookie()did not include theSameSiteattribute in the$optionsarray passed tosetcookie(), whileSession::configure()andSession::setCookie()set it according toConfig\Cookie::$samesite. This change stores$cookieSameSitefromConfig\Cookieand passes it when destroying the cookie, defaulting empty values toLax.Checklist: